Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor

[Krzysztof Kozlowski]

On 26/10/2025 07:50, Igor Reznichenko wrote:
> +properties:
> +  compatible:
> +    const: st,tsc1641

Subject: I asked to drop "binding" and not add "support for". "Support
for" makes little sense in terms of binding. How binding can support
anything? This is the "ST TSC1641 power monitor" not support.

> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description: Shunt resistor value in micro-ohms. Since device has internal
> +      16-bit RSHUNT register with 10 uOhm LSB, the maximum value is capped at
> +      655.35 mOhm.
> +    minimum: 100
> +    default: 1000
> +    maximum: 655350
> +
> +  st,alert-polarity-active-high:

Isn't this just interrupt? You need proper interrupts property and then
its flag define the type of interrupt.


Best regards,
Krzysztof