Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor

[Guenter Roeck]

On 10/26/25 12:41, Krzysztof Kozlowski wrote:
> On 26/10/2025 19:46, Igor Reznichenko wrote:
> > > Subject: I asked to drop "binding" and not add "support for". "Support
> > > for" makes little sense in terms of binding. How binding can support
> > > anything? This is the "ST TSC1641 power monitor" not support.
> >
> > Krzysztof,
> >
> > Thanks for feedback, will fix this and will create following patch versions
> > in new threads.
> >
> > > > +
> > > > +  reg:
> > > > +    maxItems: 1
> > > > +
> > > > +  shunt-resistor-micro-ohms:
> > > > +    description: Shunt resistor value in micro-ohms. Since device has internal
> > > > +      16-bit RSHUNT register with 10 uOhm LSB, the maximum value is capped at
> > > > +      655.35 mOhm.
> > > > +    minimum: 100
> > > > +    default: 1000
> > > > +    maximum: 655350
> > > > +
> > > > +  st,alert-polarity-active-high:
> > >
> > > Isn't this just interrupt? You need proper interrupts property and then
> > > its flag define the type of interrupt.
> >
> > This controls a bit written into device register.
> > I omitted interrupt property after looking at existing power monitor bindings,
> > especially hwmon/ti,ina2xx.yaml. INA226 has very similar bit controlling alert
> > pin polarity and binding doesn't define alert pin as interrupt. Overall, I didn't
> > find many power monitor bindings defining alert pins as interrupts.
>
>
> On INA2xx that's SMBUS Alert. Is this the case here as well?

It could be wired to SMBus alert, or it could be wired to a CPU interrupt pin.

Guenter