Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

[Jijie Shao]

on 2025/10/26 21:36, Tianling Shen wrote:
> The LED registers on YT8531 are exactly same as YT8521, so simply
> reuse yt8521_led_hw_* functions.
>
> Tested on OrangePi R1 Plus LTS and Zero3.
>
> Signed-off-by: Tianling Shen <cnsztl@xxxxxxxxx>

Reviewed-by: Jijie Shao<shaojijie@xxxxxxxxxx>

> ---
>   drivers/net/phy/motorcomm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index a3593e663059..89b5b19a9bd2 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -3048,6 +3048,9 @@ static struct phy_driver motorcomm_phy_drvs[] = {
>   		.get_wol	= ytphy_get_wol,
>   		.set_wol	= yt8531_set_wol,
>   		.link_change_notify = yt8531_link_change_notify,
> +		.led_hw_is_supported = yt8521_led_hw_is_supported,
> +		.led_hw_control_set = yt8521_led_hw_control_set,
> +		.led_hw_control_get = yt8521_led_hw_control_get,
>   	},
>   	{
>   		PHY_ID_MATCH_EXACT(PHY_ID_YT8531S),