Re: [PATCH v3] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller

[Krishna Kurapati PSSNV]

On 10/27/2025 2:06 PM, Konrad Dybcio wrote:
> On 10/24/25 8:21 PM, Krishna Kurapati wrote:
> > Enable OTG support for primary USB controller on EVK Platform. Add
> > HD3SS3220 Type-C port controller present between Type-C port and SoC
> > that provides role switch notifications to controller.
> >
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > ---
> > Changes in v3:
> > - Moved "usb-role-switch" to lemans dtsi file
> > - Moved vbus supply to connector node
> >
> > Link to v3 bindings and driver support:
> > https://lore.kernel.org/all/20251024181832.2744502-1-krishna.kurapati@xxxxxxxxxxxxxxxx/
> >
> > Link to v2:
> > https://lore.kernel.org/all/20251008180036.1770735-1-krishna.kurapati@xxxxxxxxxxxxxxxx/
> >
> >   arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
> >   arch/arm64/boot/dts/qcom/lemans.dtsi    |   1 +
> >   2 files changed, 121 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > index c7dc9b8f4457..2baad2612b16 100644
> > --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > @@ -37,6 +37,35 @@ chosen {
> >   		stdout-path = "serial0:115200n8";
> >   	};
> >   
> > +	connector0 {
>
> "connector-0"
>
> [...]

ACK.

> > +	vbus_supply_regulator_0: vbus-supply-regulator-0 {
>
> Other regulators (as can be seen in the diff context below) are
> named regulator-xyz-abc, please follow

ACK.

> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vbus_supply_0";
> > +		gpio = <&expander1 2 GPIO_ACTIVE_HIGH>;
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +		enable-active-high;
> > +	};
> > +
> >   	vmmc_sdc: regulator-vmmc-sdc {
> >   		compatible = "regulator-fixed";
>
> [...]
>
> >   &usb_0 {
> > -	dr_mode = "peripheral";
> > -
> >   	status = "okay";
> > +
> > +	ports {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		port@0 {
> > +			reg = <0>;
> > +
> > +			usb3_hs_ep: endpoint {
>
> Please define these ports in the SoC DTSI and plumb them through &labels
> in this one

ACK.

Will update in v4.

Regards,
Krishna,