Re: [PATCH net-next v3 01/12] net: dsa: lantiq_gswip: split into common and MMIO parts

[Sverdlin, Alexander]

Hi Daniel,

On Sun, 2025-10-26 at 23:43 +0000, Daniel Golle wrote:
> Move all parts specific for the MMIO/SoC driver into a module of its own
> to prepare for supporting MDIO-connected switch ICs.
> Modify gswip_probe() functions by splitting it into a common function
> gswip_probe_common() which covers allocating, initializing and registering
> the DSA switch, while keeping transport-specific regmap initialization as
> well as PHY firmware loading in the new MMIO/SoC-specific gswip_probe()
> function.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

thanks for the patch!

Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

(with GSW145)

> ---
>  drivers/net/dsa/lantiq/Kconfig               |    6 +-
>  drivers/net/dsa/lantiq/Makefile              |    1 +
>  drivers/net/dsa/lantiq/lantiq_gswip.c        | 1617 +----------------
>  drivers/net/dsa/lantiq/lantiq_gswip.h        |    4 +
>  drivers/net/dsa/lantiq/lantiq_gswip_common.c | 1622 ++++++++++++++++++
>  5 files changed, 1658 insertions(+), 1592 deletions(-)
>  create mode 100644 drivers/net/dsa/lantiq/lantiq_gswip_common.c

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com