Re: [PATCH net-next v3 09/12] net: dsa: lantiq_gswip: add vendor property to setup MII refclk output

[Sverdlin, Alexander]

Hi Daniel,

On Sun, 2025-10-26 at 23:47 +0000, Daniel Golle wrote:
> Read boolean Device Tree property "maxlinear,rmii-refclk-out" and switch
> the RMII reference clock to be a clock output rather than an input if it
> is set.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

thanks for the patch!

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>
Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

(with GSW145)

> ---
>  drivers/net/dsa/lantiq/lantiq_gswip_common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq/lantiq_gswip_common.c b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> index 60a83093cd10..bf38ecc13f76 100644
> --- a/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> +++ b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> @@ -1442,6 +1442,10 @@ static void gswip_phylink_mac_config(struct phylink_config *config,
>  		return;
>  	}
>  
> +	if (of_property_read_bool(dp->dn, "maxlinear,rmii-refclk-out") &&
> +	    !(miicfg & GSWIP_MII_CFG_MODE_RGMII))
> +		miicfg |= GSWIP_MII_CFG_RMII_CLK;
> +

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com