Re: [PATCH net-next v3 11/12] net: dsa: add tagging driver for MaxLinear GSW1xx switch family

[Sverdlin, Alexander]

Hi Daniel,

On Sun, 2025-10-26 at 23:48 +0000, Daniel Golle wrote:
> Add support for a new DSA tagging protocol driver for the MaxLinear
> GSW1xx switch family. The GSW1xx switches use a proprietary 8-byte
> special tag inserted between the source MAC address and the EtherType
> field to indicate the source and destination ports for frames
> traversing the CPU port.
> 
> Implement the tag handling logic to insert the special tag on transmit
> and parse it on receive.
> 
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

thanks for the patch!

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>
Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

(with GSW145)

> ---
> since RFC:
>  * use dsa etype header macros instead of open coding them
>  * maintain alphabetic order in Kconfig and Makefile
> 
>  MAINTAINERS              |   3 +-
>  include/net/dsa.h        |   2 +
>  net/dsa/Kconfig          |   8 +++
>  net/dsa/Makefile         |   1 +
>  net/dsa/tag_mxl-gsw1xx.c | 141 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 154 insertions(+), 1 deletion(-)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com