Re: [PATCH 7/7] gpu: nova-core: justify remaining uses of `as`
From: Alexandre Courbot
Date: Mon Oct 27 2025 - 08:07:43 EST
On Mon Oct 27, 2025 at 1:11 AM JST, Miguel Ojeda wrote:
> On Sun, Oct 26, 2025 at 3:40 PM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>>
>> + // `as u32` is used on purpose since we do want to strip the upper bits, which will be
>> + // written to `NV_PFALCON_FALCON_DMATRFBASE1`.
>> .set_base((dma_start >> 8) as u32)
>> .write(bar, &E::ID);
>
> We are not very consistent on this yet, but I would suggest using `//
> CAST:`. We are working on getting `// PANIC:` in Clippy, and we could
> get others like this one eventually.
Sounds great, will do!