Re: linux-next: build failure after merge of the pwm tree
From: Uwe Kleine-König
Date: Mon Oct 27 2025 - 09:47:51 EST
Hello Greg,
On Mon, Oct 27, 2025 at 09:11:35AM +0100, Uwe Kleine-König wrote:
> On Mon, Oct 27, 2025 at 12:51:48PM +1100, Stephen Rothwell wrote:
> > After merging the pwm tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > error[E0277]: the trait bound `core::result::Result<core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, kernel::error::Error>: PinInit<Th1520PwmPlatformDriver, kernel::error::Error>` is not satisfied
> > --> drivers/pwm/pwm_th1520.rs:331:10
> > |
> > 331 | ) -> Result<Pin<KBox<Self>>> {
> > | ^^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound
> > |
> > = help: the trait `PinInit<Th1520PwmPlatformDriver, kernel::error::Error>` is not implemented for `Result<Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, Error>`
> > but trait `PinInit<core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>, kernel::error::Error>` is implemented for it
> > = help: for that trait implementation, expected `core::pin::Pin<Box<Th1520PwmPlatformDriver, Kmalloc>>`, found `Th1520PwmPlatformDriver`
> > note: required by a bound in `kernel::platform::Driver::{synthetic#0}`
> > --> rust/kernel/platform.rs:196:15
> > |
> > 196 | ) -> impl PinInit<Self, Error>;
> > | ^^^^^^^^^^^^^^^^^^^^ required by this bound in `Driver::{synthetic#0}`
> >
> > error: aborting due to 1 previous error
> >
> > For more information about this error, try `rustc --explain E0277`.
> >
> > Caused by commit
> >
> > fb3957af9ec6 ("pwm: Add Rust driver for T-HEAD TH1520 SoC")
> >
> > presumably interacting with something merged earlier in my tree.
> > If someone could provide me with an appropriate merge resolution, I will
> > apply it.
>
> Having no relevant clue about Rust, I bisected that. The bisection points to
> 0242623384c7 ("rust: driver: let probe() return impl PinInit<Self, Error>").
To make it easy for Linus to merge my pwm tree during the next merge
window, it would be great if it could contain the conflict resolution.
Can I assume that this commit is stable, will be part of your next MR
and are you ok if I merge it into my tree with the fix for the conflict?
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature