Re: [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

From: Krzysztof Kozlowski

Date: Mon Oct 27 2025 - 10:11:26 EST


On 24/10/2025 00:22, Roy Luo wrote:
>>> +
>>> + clocks:
>>> + items:
>>> + - description: USB2 PHY clock.
>>> + - description: USB2 PHY APB clock.
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: usb2_phy
>>
>> core
>>
>>> + - const: u2phy_apb
>>
>> apb
>>
>
> Just to provide the full context, these two clocks/resets
> (usb2_phy and u2phy_apb) are specifically for eUSB2 PHY.
> USB3/DP combo PHY has its own clock/reset that hasn't
> been added yet, we would have to differentiate them once

That's confusing a bit. You must add all clocks, all resets, all power
domains, all pins etc. Bindings are supposed to be complete, see writing
bindings doc.


Best regards,
Krzysztof