Re: [PATCH net-next 03/12] selftests/vsock: reuse logic for vsock_test through wrapper functions

From: Bobby Eshleman
Date: Mon Oct 27 2025 - 14:02:17 EST


On Mon, Oct 27, 2025 at 04:58:02PM +0000, Simon Horman wrote:
> On Wed, Oct 22, 2025 at 06:00:07PM -0700, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@xxxxxxxx>
> >
> > Add wrapper functions vm_vsock_test() and host_vsock_test() to invoke
> > the vsock_test binary. This encapsulates several items of repeat logic,
> > such as waiting for the server to reach listening state and
> > enabling/disabling the bash option pipefail to avoid pipe-style logging
> > from hiding failures.
> >
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@xxxxxxxx>
>
> shellcheck has some (new) things to say about this patch too.
> Could you take a look over them?
>
> ...

No problem, will do.

Thanks for the reviews!

Best,
Bobby