Re: [PATCH net-next 0/6] xfrm docs update

From: Randy Dunlap

Date: Sat Nov 01 2025 - 00:58:35 EST




On 10/29/25 1:26 AM, Bagas Sanjaya wrote:
> Hi,
>
> Here are xfrm documentation patches. Patches [1-4/6] are formatting polishing;
> [5/6] groups the docs and [6/6] adds MAINTAINERS entries for them.
>
> Enjoy!
>
> Bagas Sanjaya (6):
> Documentation: xfrm_device: Wrap iproute2 snippets in literal code
> block
> Documentation: xfrm_device: Use numbered list for offloading steps
> Documentation: xfrm_device: Separate hardware offload sublists
> Documentation: xfrm_sync: Properly reindent list text
> net: Move XFRM documentation into its own subdirectory
> MAINTAINERS: Add entry for XFRM documentation

LGTM. Thanks.

for the series:
Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

OK, one small nit. 3 of the section headings end with ':'
that should not be there. See xfrm/index.html:

XFRM Framework
XFRM device - offloading the IPsec computations
Overview
Callbacks to implement
Flow
XFRM proc - /proc/net/xfrm_* files
Transformation Statistics
XFRM sync
1) Message Structure
2) TLVS reflect the different parameters:
3) Default configurations for the parameters:
4) Message types
Exceptions to threshold settings
XFRM Syscall
/proc/sys/net/core/xfrm_* Variables:

Oh, and could/should
Exceptions to threshold settings
be numbered, 5) ? It looks odd to be unnumbered.

--
~Randy