Re: [PATCH net-next v2 1/2] net: mana: Refactor GF stats to use global mana_context

From: Jakub Kicinski

Date: Fri Oct 31 2025 - 19:06:34 EST


On Wed, 29 Oct 2025 03:37:51 -0700 Erni Sri Satya Vennela wrote:
> Refactor mana_query_gf_stats() to use mana_context instead of per-port,
> enabling single query for all VFs.

What does "single query for all VFs" mean?
All types? All within the host?

Coincidentally I don't know what HC and GF stand for.
Please explain things in more detail, all atypical acronyms
(for *Linux* networking).

> Isolate hardware counter stats by introducing mana_ethtool_hc_stats
> in mana_context and update the code to ensure all stats are properly
> reported via ethtool -S <interface>, maintaining consistency with
> previous behavior.

> -void mana_query_gf_stats(struct mana_port_context *apc)
> +void mana_query_gf_stats(struct mana_context *ac)
> {
> struct mana_query_gf_stat_resp resp = {};
> struct mana_query_gf_stat_req req = {};
> - struct net_device *ndev = apc->ndev;
> + struct gdma_context *gc = ac->gdma_dev->gdma_context;

reverse xmas tree, please

> + struct device *dev = gc->dev;
> int err;