Re: [patch V3 06/12] rseq: Implement sys_rseq_slice_yield()
From: Thomas Gleixner
Date: Fri Oct 31 2025 - 17:07:11 EST
On Fri, Oct 31 2025 at 15:46, Mathieu Desnoyers wrote:
> On 2025-10-29 09:22, Thomas Gleixner wrote:
>>
>> +/**
>> + * sys_rseq_slice_yield - yield the current processor if a task granted
>> + * with a time slice extension is done with the
>> + * critical work before being forced out.
>> + *
>> + * On entry from user space, syscall_entry_work() ensures that NEED_RESCHED is
>> + * set if the task was granted a slice extension before arriving here.
>> + *
>> + * Return: 1 if the task successfully yielded the CPU within the granted slice.
>> + * 0 if the slice extension was either never granted or was revoked by
>> + * going over the granted extension or being scheduled out earlier
>
> I notice the presence of tabs in those comments. You will likely want
> to convert those to spaces.
And why so? It's perfectly formatted and there is ZERO reason to use
spaces in comments when you want to have aligned formatting.
Thanks,
tglx