Re: [tip: objtool/core] objtool/klp: Add --debug option to show cloning decisions

[Nathan Chancellor]

On Fri, Oct 31, 2025 at 09:11:44AM -0700, Josh Poimboeuf wrote:
> On Fri, Oct 31, 2025 at 03:21:00PM +0100, Borislav Petkov wrote:
> > On Fri, Oct 31, 2025 at 10:09:44AM -0400, Nathan Chancellor wrote:
> > > Yeah, that looks good to me and matches the workaround that Peter did in
> > > include/linux/compiler-clang.h. If cleanup is going to be used more in
> > > objtool, it might be worth taking that approach there too like:
> > > 
> > >   #ifdef __clang__
> > >   #define __cleanup(func) __maybe_unused __attribute__((__cleanup__(func)))
> > >   #else
> > >   #define __cleanup(func) __attribute__((__cleanup__(func)))
> > >   #endif
> > 
> > LGTM.
> > 
> > I'll wait for the objool-er folks to lemme know what they want before
> > I productize it.
> > 
> > Thx Nathan!
> 
> How about __maybe_unused unconditionally without the #ifdef damage?

Yeah I had only suggested that to mirror the kernel but fundamentally,
GCC already treats it that way so I don't think there is any harm in
just doing this unconditionally.

Nathan