Re: [PATCH v22 03/28] riscv: zicfiss / zicfilp enumeration

[Paul Walmsley]

On Thu, 23 Oct 2025, Deepak Gupta wrote:

> This patch adds support for detecting zicfiss and zicfilp. zicfiss and
> zicfilp stands for unprivleged integer spec extension for shadow stack
> and branch tracking on indirect branches, respectively.
> 
> This patch looks for zicfiss and zicfilp in device tree and accordinlgy
> lights up bit in cpu feature bitmap. Furthermore this patch adds detection
> utility functions to return whether shadow stack or landing pads are
> supported by cpu.
> 
> Reviewed-by: Zong Li <zong.li@xxxxxxxxxx>
> Reviewed-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>
> Signed-off-by: Deepak Gupta <debug@xxxxxxxxxxxx>

This patch introduces some 'checkpatch.pl --strict' messages:

CHECK: Alignment should match open parenthesis
#68: FILE: arch/riscv/kernel/cpufeature.c:278:
+static int riscv_cfilp_validate(const struct riscv_isa_ext_data *data,
+			      const unsigned long *isa_bitmap)

CHECK: Alignment should match open parenthesis
#77: FILE: arch/riscv/kernel/cpufeature.c:287:
+static int riscv_cfiss_validate(const struct riscv_isa_ext_data *data,
+			      const unsigned long *isa_bitmap)


I'll fix them up here in the event that v22 goes in, but please do the 
same on your side in case a new version is needed.  


thanks,

- Paul