Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor
From: Guenter Roeck
Date: Fri Oct 31 2025 - 14:37:06 EST
On 10/31/25 10:30, Igor Reznichenko wrote:
On 10/28/25 08:17, Igor Reznichenko wrote:
Understood. The bit in question controls the alert pin polarity on the device side,
independent of whether the pin is used as interrupt or not. I'll drop the property
for now and revisit if there's a board that actually uses an inverter or needs to
program the bit explicitly.
This is kind of unusual. The requirement used to be that devicetree properties
shall be complete. "Only if there is a known use case" is a significant policy
change. Has the policy changed recently ?
Thanks,
Guenter
Rob, following up on Guenter's question above.
I'm not sure whether it's better to drop the property as discussed earlier or keep
it for binding completeness.
Could you clarify what approach is preferred?
Don't you have there possibility of interrupt (not only SMBus Alert)? At
least this is what I understood from previous talks.
Yes, the alert pin could be used as interrupt in principle.
Datasheet calls it "Multi-functional digital alert pin".
Maybe you could try adding an optional "interrupts" property.
Guenter