Re: [PATCH v3 5/5] sample: rust: pci: add tests for config space routines

[Danilo Krummrich]

On Thu Oct 30, 2025 at 4:48 PM CET, Zhi Wang wrote:
> +    fn config_space(pdev: &pci::Device<Core>) -> Result {
> +        let config = pdev.config_space()?;
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read8 rev ID: {:x}\n",
> +            config.try_read8(0x8)?
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read16 vendor ID: {:x}\n",
> +            config.try_read16(0)?
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read32 BAR 0: {:x}\n",
> +            config.try_read32(0x10)?
> +        );
> +
> +        Ok(())
> +    }
>  }

Please use the infallible accessors and add a TODO to use the register!() macro
for defining PCI configuration space registers once it has been move out of
nova-core.