Re: [PATCH v3 0/3] NVIDIA Tegra210 NVJPG support

[Jon Hunter]

On 04/07/2025 10:04, Thierry Reding wrote:
> On Mon, Jun 30, 2025 at 09:48:41AM +0100, Diogo Ivo wrote:
> > Hello,
> >
> > This series adds support for the NVJPG hardware accelerator found in the
> > Tegra210 SoC.
> >
> > The kernel driver is essentially a copy of the NVDEC driver as both
> > engines are Falcon-based.
> >
> > For the userspace part I have written a Mesa Gallium backend [1] that,
> > while still very much experimental, works in decoding images with VA-API.
> >
> > I have been using ffmpeg to call VA-API with the following command:
> >
> > ffmpeg -v verbose -hwaccel vaapi -hwaccel_device /dev/dri/renderD129 -i <input.jpg> -pix_fmt bgra -f fbdev /dev/fb0
> >
> > which decodes <input.jpg> and shows the result in the framebuffer.
> >
> > The firmware for the engine can be obtained from a Linux for Tegra
> > distribution. Due to the way the Gallium implementation works for Tegra
> > the GPU also needs to be enabled.
> >
> > Thanks!
> >
> > Diogo
> >
> > To: Thierry Reding <thierry.reding@xxxxxxxxx>
> > To: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> > To: David Airlie <airlied@xxxxxxxxx>
> > To: Simona Vetter <simona@xxxxxxxx>
> > To: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> > To: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > To: Rob Herring <robh@xxxxxxxxxx>
> > To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > To: Conor Dooley <conor+dt@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-tegra@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Signed-off-by: Diogo Ivo <diogo.ivo@xxxxxxxxxxxxxxxxxx>
> >
> > [1]: https://gitlab.freedesktop.org/d.ivo/mesa/-/tree/diogo/vaapi_gl?ref_type=heads
>
> Dave, Simona,
>
> This doesn't add new userspace ABI and instead reuses the same ABI that
> we use for VIC and NVDEC, but it does technically add a new driver for
> one of the multimedia engines.
>
> Given that we have Diogo's VA-API work on gitlab, I think all of the
> criteria are met to exercise this.
>
> If you don't have any objections, I'd like to apply this for the
> upcoming release.

We would like to merge this for v6.19 and so please let us know if you 
have any objections.

For the series ...

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Cheers
Jon

--
nvpublic