Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5

[Romli, Khairul Anuar]

On 31/10/2025 4:00 pm, Krzysztof Kozlowski wrote:
> On 31/10/2025 00:08, Romli, Khairul Anuar wrote:
>> On 31/10/2025 12:33 am, Krzysztof Kozlowski wrote:
>>>> I was excluding the iommu in the current patch series, not that I meant
>>>> there is no iommu. It was meant for the future patches that will include
>>>
>>> Read your bindings again. They clearly do not list IOMMU, meaning there
>>> is no IOMMU.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I will add that in the next revision also after going through
>> https://www.kernel.org/doc/Documentation/devicetree/bindings/writing-bindings.rst
>>
>> One question, if the property only meant for a specific compatible, do
>> you accept the logical "if" statement to ensure that the property only
>> for specific device but not others?
>
> Yes, see example-schema how to do it (and property is always described
> in top-level).
>
> Best regards,
> Krzysztof

Great, I will see the example-schema and also go through the already
implemented bindings that has the relevant changes.

Thanks.

Best Regards,
Khairul