Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor

From: Krzysztof Kozlowski

Date: Fri Oct 31 2025 - 03:57:52 EST


On 31/10/2025 05:40, Igor Reznichenko wrote:
>> On 10/28/25 08:17, Igor Reznichenko wrote:
>>> Understood. The bit in question controls the alert pin polarity on the device side,
>>> independent of whether the pin is used as interrupt or not. I'll drop the property
>>> for now and revisit if there's a board that actually uses an inverter or needs to
>>> program the bit explicitly.
>>>
>>
>> This is kind of unusual. The requirement used to be that devicetree properties
>> shall be complete. "Only if there is a known use case" is a significant policy
>> change. Has the policy changed recently ?
>>
>> Thanks,
>> Guenter
>
> Rob, following up on Guenter's question above.
> I'm not sure whether it's better to drop the property as discussed earlier or keep
> it for binding completeness.
> Could you clarify what approach is preferred?

Don't you have there possibility of interrupt (not only SMBus Alert)? At
least this is what I understood from previous talks.

Best regards,
Krzysztof