Re: [PATCH v3 6/6] panic: sys_info: Factor out read and write handlers

From: Andy Shevchenko

Date: Fri Oct 31 2025 - 03:22:21 EST


On Thu, Oct 30, 2025 at 08:16:12PM -0700, Andrew Morton wrote:
> On Thu, 30 Oct 2025 12:44:22 +0100 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> checkpatch wanted this:

Makes sense. Have you applied this update to your tree already? Or should I
send (re-send) a formal patch?

> --- a/lib/sys_info.c~panic-sys_info-factor-out-read-and-write-handlers-checkpatch-fixes
> +++ a/lib/sys_info.c
> @@ -43,7 +43,7 @@ unsigned long sys_info_parse_param(char
>
> #ifdef CONFIG_SYSCTL
>
> -static int sys_info_write_handler(struct ctl_table *table,
> +static int sys_info_write_handler(const struct ctl_table *table,
> void *buffer, size_t *lenp, loff_t *ppos,
> unsigned long *si_bits_global)
> {
> @@ -62,7 +62,7 @@ static int sys_info_write_handler(struct
> return 0;
> }
>
> -static int sys_info_read_handler(struct ctl_table *table,
> +static int sys_info_read_handler(const struct ctl_table *table,
> void *buffer, size_t *lenp, loff_t *ppos,
> unsigned long *si_bits_global)
> {

Thank you for the review!

--
With Best Regards,
Andy Shevchenko