Re: [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform

[Bjorn Andersson]

On Thu, Oct 30, 2025 at 06:53:59AM +0100, Krzysztof Kozlowski wrote:
> On 29/10/2025 18:23, Bjorn Andersson wrote:
> > On Wed, Oct 29, 2025 at 04:49:30PM +0100, Krzysztof Kozlowski wrote:
> >> On 29/10/2025 09:15, Jingyi Wang wrote:
> >>> diff --git a/include/dt-bindings/mailbox/qcom,glymur-ipcc.h b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> >>> new file mode 100644
> >>> index 000000000000..3ab8189974a5
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> >>> @@ -0,0 +1,68 @@
> >>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> >>> +/*
> >>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> >>> + */
> >>> +
> >>> +#ifndef __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> >>> +#define __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> >>> +
> >>> +/* Glymur physical client IDs */
> >>> +#define IPCC_MPROC_AOP			0
> >>
> >>
> >> Here the same - not used by Linux.
> > 
> > How is this different from e.g.:
> > 
> > include/dt-bindings/interrupt-controller/arm-gic.h:#define GIC_SPI 0
> 
> $ git grep GIC_SPI
> drivers/irqchip/irq-mchp-eic.c
> 

My interpretation of that snippet (and the other use cases) is that they
are programmatically constructing the values of a DT property, not that
they define the SW API.

> How is this not used by Linux? What is drivers/irqchip/foo.c if not a
> Linux driver?
> 

No argument there.

[..]
> > 
> >> Or provide explanation in terms what Linux interface you are binding
> >> here (please focus on Linux or other SW).
> >>
> > 
> > Don't we use include/dt-bindings to define hardware constants for use in
> 
> No, we do not.
> 

I have completely missed this. Perhaps this is the first use case, but
the result is non-the-less:

$ find arch/*/boot/dts/qcom -name '*.h' | wc -l
0


But this makes sense, and I like it.

@Jingyi, as these header constants are consumed only by DeviceTree
source, please move them to arch/arm64/boot/dts/qcom/

Thanks,
Bjorn