Re: maple_tree.c:3738:1: error: the frame size of 1040 bytes is larger than 1024 bytes

[Christian Kujau]

On Thu, 30 Oct 2025, Christian Kujau wrote:
> > Oh, and the WARN_ON_ONCE() in there is all wrong.
> > A WARN_ON_ONCE(type != wr_split_store) after the call to mas_rebalance()
> > might make sense.
> 
> I'll leave that for someone else to fix :-)

OK, something like this maybe, but I don't understand this, so it doesn't 
feel right to propose this myself.

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 949fd2a0554b..6158933cfd01 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3062,11 +3062,11 @@ static noinline_for_kasan void mas_commit_b_node(struct ma_wr_state *wr_mas,
 {
 	enum store_type type = wr_mas->mas->store_type;
 
-	WARN_ON_ONCE(type != wr_rebalance && type != wr_split_store);
-
 	if (type == wr_rebalance)
 		return mas_rebalance(wr_mas->mas, b_node);
 
+	WARN_ON_ONCE(type != wr_split_store);
+
 	return mas_split(wr_mas->mas, b_node);
 }

Christian.
-- 
BOFH excuse #135:

You put the disk in upside down.