Re: [PATCH] rust_binder: use compat_ptr_ioctl
From: Greg Kroah-Hartman
Date: Thu Oct 30 2025 - 11:06:17 EST
On Thu, Oct 30, 2025 at 01:25:19PM +0000, Alice Ryhl wrote:
> On Thu, Oct 30, 2025 at 01:38:56PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Oct 30, 2025 at 10:41:04AM +0000, Alice Ryhl wrote:
> > > This is commit 1832f2d8ff69 ("compat_ioctl: move more drivers to
> > > compat_ptr_ioctl") but for Rust Binder.
> >
> > You might want to spell out why this is happening, not just refer to
> > another commit to try to find that information to make it more clear
> > here as to how to attempt to review this :)
>
> I can replace the commit message with:
>
> Binder always treats the ioctl argument as a pointer. In this scenario,
> the idiomatic way to implement compat_ioctl is to use compat_ptr_ioctl.
> Thus update Rust Binder to do that.
Sounds good to me!