RE: [PATCH 06/19] serial: sh-sci: Drop extra line
From: Biju Das
Date: Thu Oct 30 2025 - 10:43:53 EST
Hi Hugo,
> -----Original Message-----
> From: Hugo Villeneuve <hugo@xxxxxxxxxxx>
> Sent: 28 October 2025 14:35
> Subject: Re: [PATCH 06/19] serial: sh-sci: Drop extra line
>
> Hi Biju,
>
> On Mon, 27 Oct 2025 15:45:53 +0000
> Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
>
> > Shorten the number lines in sci_init_clocks() by fitting the error
> > message within an 80-character length limit.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > drivers/tty/serial/sh-sci.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index b33894d0273b..699c39b81c4b 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -3009,8 +3009,7 @@ static int sci_init_clocks(struct sci_port
> > *sci_port, struct device *dev)
> >
> > if (!clk && sci_port->type == SCI_PORT_RSCI &&
> > (i == SCI_FCK || i == SCI_BRG_INT)) {
> > - return dev_err_probe(dev, -ENODEV,
> > - "failed to get %s\n",
> > + return dev_err_probe(dev, -ENODEV, "failed to get %s\n",
> > name);
>
> You can even put it all on one line with the now 100 columns limit.
Ok will fit into 100 columns limit.
Cheers,
Biju