Re: [PATCH v2] crypto: qat - use simple_strtoull to improve qat_uclo_parse_num

From: Andy Shevchenko

Date: Thu Oct 30 2025 - 10:03:16 EST


On Thu, Oct 30, 2025 at 11:27:37AM +0000, Giovanni Cabiddu wrote:
> On Mon, Oct 27, 2025 at 11:02:16AM +0200, Andy Shevchenko wrote:
> > On Sun, Oct 26, 2025 at 02:57:07AM +0100, Thorsten Blum wrote:
> > > Replace the manual string copying and parsing logic with a call to
> > > simple_strtoull() to simplify and improve qat_uclo_parse_num().
> > >
> > > Ensure that the parsed number does not exceed UINT_MAX, and add an
> > > approximate upper-bound check (no more than 19 digits) to guard against
> > > overflow.
> >
> > Reviewed-by; Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> s/;/:
>
> I just noticed this while applying the patch to my local tree.
>
> Due to the typo, patchwork is not applying your tag [1].

Oh, thanks for catching this. Have you added it manually or should I do
something about it?

> [1] https://patchwork.kernel.org/project/linux-crypto/patch/20251026015710.1368-1-thorsten.blum@xxxxxxxxx/mbox/

--
With Best Regards,
Andy Shevchenko