Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

From: Zhongqiu Han

Date: Thu Oct 30 2025 - 09:11:46 EST


On 10/30/2025 8:32 PM, Greg KH wrote:
On Thu, Oct 30, 2025 at 08:30:00PM +0800, Zhongqiu Han wrote:
Append newline characters to sysfs_emit() outputs in func max_conn_show(),
fixed_show(), and vtag_show(). This aligns with common kernel conventions
and improves readability for userspace tools that expect
newline-terminated values.

What userspace tool reads these values today? Will this user/kernel api
break them? How was this tested?

thanks,

greg k-h

Hi Greg,
Thanks for your review~

Apologies for the confusion in the commit message — there isn't
actually a userspace tool that depends on the newline in this case. I
just made the change to follow common sysfs formatting practices and
improve consistency.

If you'd prefer the patch to be dropped or revised, I will proceed
accordingly.

--
Thx and BRs,
Zhongqiu Han