Re: [PATCH v2 1/1] firmware: stratix10-svc: fix bug in saving controller data

From: Dinh Nguyen

Date: Thu Oct 30 2025 - 07:48:18 EST




On 10/29/25 07:31, Khairul Anuar Romli wrote:
Fix the incorrect usage of platform_set_drvdata and dev_set_drvdata. They
both are of the same data and overrides each other. This resulted in the
rmmod of the svc driver to fail and throw a kernel panic for kthread_stop
and fifo free.

Fixes: bf0e5bf68a20 ("firmware: stratix10-svc: extend svc to support new RSU features")
cc: stable@xxxxxxxxxxxxxxx # 6.6+

Please read the stable kernel rules documentation for future submissions:

stable-kernel-rules.rst


Signed-off-by: Ang Tien Sung <tiensung.ang@xxxxxxxxxx>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
---
Changes in v2:
- Add CC that was missed in the v1 and original patch from 2023
---
drivers/firmware/stratix10-svc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)


This patch does not apply cleanly on v6.18-rc1. Please rebase and resubmit.

Thanks,
Dinh