Re: [PATCH 3/7] arm64: dts: qcom: sc8180x: create common zap-shader node
From: Konrad Dybcio
Date: Thu Oct 30 2025 - 06:59:04 EST
On 10/30/25 11:58 AM, Konrad Dybcio wrote:
> On 10/28/25 10:00 PM, Dmitry Baryshkov wrote:
>> In order to reduce duplication, move common GPU memory configuration
>> from individual board files to sc8180x.dtsi.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> ---
>
> [...]
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
>> index 93de9fe918ebdadf239832db647b84ac9d5a33f6..069953dcad378448800d45e14931efe1fe1a69fc 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
>> @@ -14,6 +14,8 @@
>> #include "sc8180x.dtsi"
>> #include "sc8180x-pmics.dtsi"
>>
>> +/delete-node/ &gpu_mem;
>> +
>> / {
>> model = "Qualcomm SC8180x Primus";
>> compatible = "qcom,sc8180x-primus", "qcom,sc8180x";
>> @@ -444,7 +446,6 @@ &gpu {
>> status = "okay";
>>
>> zap-shader {
>> - memory-region = <&gpu_mem>;
>
> Hm?
I "hm"d at the wrong line.. why are we delete-node-ing gpu_mem?
Konrad