Re: [PATCH] sched/core: Remove double update_rq_clock() in __set_cpus_allowed_ptr_locked()

[Peter Zijlstra]

On Thu, Oct 30, 2025 at 09:34:00AM +0530, K Prateek Nayak wrote:
> Hello Hao,
> 
> On 10/29/2025 3:06 PM, Hao Jia wrote:
> > From: Hao Jia <jiahao1@xxxxxxxxxxx>
> > 
> > Since commit d4c64207b88a ("sched: Cleanup the sched_change NOCLOCK usage"),
> > update_rq_clock() is called in do_set_cpus_allowed() -> sched_change_begin()
> > to update the rq clock. This results in a duplicate call update_rq_clock()
> > in __set_cpus_allowed_ptr_locked().
> > 
> > While holding the rq lock and before calling do_set_cpus_allowed(),
> > there is nothing that depends on an updated rq_clock.
> 
> I couldn't spot any dependency on rq_clock() until do_set_cpus_allowed()
> either so please feel free to include:
> 
> Reviewed-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>

Indeed, thanks!