Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5

[Krzysztof Kozlowski]

On Thu, Oct 30, 2025 at 11:30:09AM +0800, Khairul Anuar Romli wrote:
> Add the compatible property value so we can reuse Intel Stratix10
> Service Layer driver on Intel Agilex5 SoC platform.
> 
> This addition is an initial Agilex5 service layer driver enablement that
> will involve adding IOMMU changes in the future.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> ---
> Changes in v2:
> 	- Add driver compatible for Agilex5-svc
> ---
>  drivers/firmware/stratix10-svc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index e3f990d888d7..afc6c8b43e98 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -1117,6 +1117,7 @@ EXPORT_SYMBOL_GPL(stratix10_svc_free_memory);
>  static const struct of_device_id stratix10_svc_drv_match[] = {
>  	{.compatible = "intel,stratix10-svc"},
>  	{.compatible = "intel,agilex-svc"},
> +	{.compatible = "intel,agilex5-svc"},

So device is fully compatible - drop this change and express
compatibility in the bindings (see writing bindings, writing schema or
slides from my last OSSE talk).

Best regards,
Krzysztof