Re: [PATCH v1 1/2] drm/panel-edp: Add override bpc quirk for generic edp

[Doug Anderson]

Hi,

On Wed, Oct 29, 2025 at 1:11 AM Ajye Huang
<ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Adding override bpc to EDP_PANEL_ENTRY3 quirk.
>
> Signed-off-by: Ajye Huang <ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)

This seems OK to me. I'd be OK with:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>


I think you could alternatively add a EDID_QUIRK_FORCE_6BPC quirk for
this panel in "drivers/gpu/drm/drm_edid.c", though I haven't tested
it. That _might_ be a better solution? Maybe Jani or someone else CCed
would have an opinion.

At first I was thinking that the quirks in "drm_edid.c" were probably
just for "DP" display, but then I just realized that they probably
also are for "eDP" panels. Specifically I think Intel hardware doesn't
use panel-edp.c so I think the only place quirks could get applied (if
an eDP panel was also used on Intel hardware) was from "drm_edid.c".

Any chance you could confirm if EDID_QUIRK_FORCE_6BPC works for you?

Does anyone else CCed have an opinion of which they like better?

-Doug