Re: accel/amdxdna: Fix incorrect command state for timed out job
From: Lizhi Hou
Date: Wed Oct 29 2025 - 14:38:56 EST
On 10/29/25 00:53, Markus Elfring wrote:
What are the duplicate statements?Would you like to clarify the usage incidence for amdxdna_cmd_set_state() calls
Sorry that I am still a little confused.
The code change is to distinguish between the job which is timed out and the job is aborted.
in combination with assignments to the variable “ret” (according to the implementation
of the affected function “aie2_sched_resp_handler”)?
https://elixir.bootlin.com/linux/v6.18-rc3/C/ident/amdxdna_cmd_set_state
Sure. amdxdna_cmd_set_state() updates the return code to command buffer. So application which issues the command will be able to get the return code.
The function return value "ret" is used by mailbox receiving kernel thread to deal with the error.
Thanks,
Lizhi
Regards,
Markus