Re: [PATCH v3] dt_bindings: sound: ti,pcm186x: convert to dtschema

[Conor Dooley]

On Wed, Oct 29, 2025 at 10:53:04AM +0530, Ranganath V N wrote:
> convert the Texas Instruments PCM186x Universal audio ADC bindings
> to DT schema.
> 
> Signed-off-by: Ranganath V N <vnranganath.20@xxxxxxxxx>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml b/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml

> +properties:
> +  compatible:
> +    enum:
> +      - ti,pcm1862
> +      - ti,pcm1863
> +      - ti,pcm1864
> +      - ti,pcm1865

Usually we want the filename to match one of compatibles in the file,
rather than have wildcards.

Secondly, the subject is not really as expected for a binding, let alone
one in sound. It should be "ASoC: dt-bindings: ".

With those,
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: changes-requested

Attachment: signature.asc
Description: PGP signature