Re: [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform

[Krzysztof Kozlowski]

On 29/10/2025 09:15, Jingyi Wang wrote:
> diff --git a/include/dt-bindings/mailbox/qcom,glymur-ipcc.h b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> new file mode 100644
> index 000000000000..3ab8189974a5
> --- /dev/null
> +++ b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> @@ -0,0 +1,68 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#ifndef __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> +#define __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> +
> +/* Glymur physical client IDs */
> +#define IPCC_MPROC_AOP			0


Here the same - not used by Linux. Don't add these, they are really not
necessary and they are not helping anyhow. For longer explanation see 2
year thread for PMIC ADC v7.

Or provide explanation in terms what Linux interface you are binding
here (please focus on Linux or other SW).

Best regards,
Krzysztof