Re: [PATCH 1/6] dt: bindings: net: add bindings for QCN6122
From: Krzysztof Kozlowski
Date: Wed Oct 29 2025 - 10:42:28 EST
On 29/10/2025 15:32, Krzysztof Kozlowski wrote:
>> interrupt-names:
>> @@ -87,6 +88,14 @@ properties:
>> items:
>> - const: wlan-smp2p-out
>>
>> + qcom,userpd:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + enum: [2, 3]
>> + description: instance ID of user PD (protection domain) in multi-PD
>> + architectures to distinguish between multiple instances
>> + of the same wifi chip used by QMI in its interface with
>> + the firmware running on Q6.
>
> Broken indentation. It is supposed to be two spaces. Look at this file -
> why are you doing this completely different?
>
> Anyway, please do not come with 2nd or 3rd property for this. We already
> have such somewhere.
And reading the driver code, this is instance ID, so not really suitable
here. Sorry, such are not allowed. See writing bindings or my last OSSE
slides.
Best regards,
Krzysztof