Re: [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates"

[Gal Pressman]

Hi Johan,

On 29/10/2025 15:29, Johan Hovold wrote:
> This reverts commit 57c49d2355729c12475554b4c51dbf830b02d08d.
> 
> Using "%pe" to print errnos is in no way mandated and a driver authors
> may chose not to use it, for example, for consistency reasons.
> 
> Drop the recently added cocci script that has gotten the build bots to
> send warning emails about perfectly valid code and which will likely
> only result in churn and inconsistency.
> 
> Link: https://lore.kernel.org/all/aQHi4nUfIlcN1ac6@xxxxxxxxxxxxxxxxxxxx/
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

The test by no means mandates authors to use %pe, as the output says:
WARNING: Consider using %pe to print PTR_ERR()

"Consider" :).

I would consider it best practice to use it, and a few drivers were
converted thanks to this test.

If the issue is with automatic build bots, then maybe this test should
be excluded from them, rather than deleted?