Re: [PATCH net-next] net: phy: nxp-c45-tja11xx: config_init restore macsec config

From: Andrew Lunn

Date: Wed Oct 29 2025 - 08:23:56 EST


On Wed, Oct 29, 2025 at 12:42:58PM +0200, Andrei Botila wrote:
> Any existing MACsec configuration should be restored when config_init is
> called.

Please could you expand the commit message. Why should they be
restored? What is clearing them? Why is this part of
link_change_notify?

By looking at the code i can see what the change is doing. But it can
be hard to say why. So the commit message should be mostly about Why?

Is this a bug fix and should be back ported?

Andrew