[PATCH v2 5/6] panic: sys_info: Deduplicate local variable 'table; assignments
From: Andy Shevchenko
Date: Wed Oct 29 2025 - 07:12:44 EST
The both handlers use the local 'table' variable and assign
the same data to it, deduplicate that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
lib/sys_info.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/sys_info.c b/lib/sys_info.c
index 027b2c432d07..c86f52644857 100644
--- a/lib/sys_info.c
+++ b/lib/sys_info.c
@@ -63,12 +63,13 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
if (!names)
return -ENOMEM;
+ table = *ro_table;
+ table.data = names;
+ table.maxlen = maxlen;
+
if (write) {
int ret;
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
ret = proc_dostring(&table, write, buffer, lenp, ppos);
if (ret)
return ret;
@@ -91,9 +92,6 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
delim = ",";
}
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
return proc_dostring(&table, write, buffer, lenp, ppos);
}
}
--
2.50.1