Re: [PATCH 3/3] slab: use new API for remaining command line parameters
From: Harry Yoo
Date: Wed Oct 29 2025 - 06:53:34 EST
On Fri, Oct 24, 2025 at 07:06:54PM +0200, Petr Tesarik wrote:
> Use core_param() and __core_param_cb() instead of __setup() or
> __setup_param() to improve syntax checking and error messages.
>
> Replace get_option() with kstrtouint(), because:
> * the latter accepts a pointer to const char,
> * these parameters should not accept ranges,
> * error value can be passed directly to parser.
>
> There is one more change apart from the parsing of numeric parameters:
> slub_strict_numa parameter name must match exactly. Before this patch the
nit: ^ slab_strict_numa
> kernel would silently accept any option that starts with the name as an
> undocumented alias.
>
> Signed-off-by: Petr Tesarik <ptesarik@xxxxxxxx>
> ---
Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx>
--
Cheers,
Harry / Hyeonggon