Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
From: Konrad Dybcio
Date: Wed Oct 29 2025 - 05:36:22 EST
On 10/28/25 5:40 PM, Luca Weiss wrote:
> Add the msm8953 CCI device string compatible.
>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 9bc99d736343..ef8f5fe3a8e1 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -15,6 +15,7 @@ properties:
> oneOf:
> - enum:
> - qcom,msm8226-cci
> + - qcom,msm8953-cci
> - qcom,msm8974-cci
> - qcom,msm8996-cci
>
> @@ -146,6 +147,7 @@ allOf:
> - contains:
> enum:
> - qcom,msm8916-cci
> + - qcom,msm8953-cci
>
> - const: qcom,msm8996-cci
Sorry for only bringing it up now - could you check whether
all the clocks that you defined are actually necessary?
It may be that you can do without CAMSS_AHB_CLK and/or
TOP_AHB_CLK
Konrad