Re: [PATCH 1/5] nvme-fc: don't hold rport lock when putting ctrl
From: Christoph Hellwig
Date: Wed Oct 29 2025 - 04:51:32 EST
On Tue, Oct 28, 2025 at 04:26:20PM +0100, Daniel Wagner wrote:
> nvme_fc_ctrl_put can acquire the rport lock when freeing the
> ctrl object:
>
> nvme_fc_ctrl_put
> nvme_fc_ctrl_free
> spin_lock_irqsave(rport->lock)
>
> Thus we can't hold the rport lock when calling nvme_fc_ctrl_put.
>
> Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>
Looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>