Re: [PATCH v16 4/4] perf tools: Merge deferred user callchains

[Steven Rostedt]

On Fri, 24 Oct 2025 15:02:03 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > The sample__merge_deferred_callchain() initializes both
> > orig_sample.deferred_callchain and the callchain. But now that it's not
> > being called, it can cause the below free to happen with junk as the
> > callchain. This needs:
> > 
> > 		else
> > 			orig_sample.deferred_callchain = false;  
> 
> Ah, so I saw crashes from here and just deleted both free()s and got on
> with things ;-)

I just downloaded your tree again and it doesn't look like it was updated.

Just didn't want you to forget about this ;)

-- Steve