Re: [PATCH v3 1/6] gpu: nova-core: replace `as` with `from` conversions where possible
From: Alexandre Courbot
Date: Tue Oct 28 2025 - 19:31:47 EST
On Wed Oct 29, 2025 at 8:12 AM JST, Alexandre Courbot wrote:
> The `as` operator is best avoided as it silently drops bits if the
> destination type is smaller that the source.
>
> For data types where this is clearly not the case, use `from` to
> unambiguously signal that these conversions are lossless.
>
> Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Unless someeone screams, I will probably merge this one patch today - it
doesn't do anything controversial and is required for another series.
Reviews welcome still.