Re: [PATCH] ptp: guard ptp_clock_gettime() if neither gettimex64 nor
From: Jakub Kicinski
Date: Tue Oct 28 2025 - 19:13:11 EST
On Tue, 28 Oct 2025 15:51:50 +0000 Kuniyuki Iwashima wrote:
> From: Richard Cochran <richardcochran@xxxxxxxxx>
> Date: Tue, 28 Oct 2025 07:09:41 -0700
> > On Tue, Oct 28, 2025 at 05:51:43PM +0800, Junjie Cao wrote:
> > > Syzbot reports a NULL function pointer call on arm64 when
> > > ptp_clock_gettime() falls back to ->gettime64() and the driver provides
> > > neither ->gettimex64() nor ->gettime64(). This leads to a crash in the
> > > posix clock gettime path.
> >
> > Drivers must provide a gettime method.
> >
> > If they do not, then that is a bug in the driver.
>
> AFAICT, only GVE does not have gettime() and settime(), and
> Tim (CCed) was preparing a fix and mostly ready to post it.
cc: Vadim who promised me a PTP driver test :) Let's make sure we
tickle gettime/setting in that test..