Re: [PATCH 0/5] gpu: nova-core: leverage FromBytes for VBIOS structures

[Alexandre Courbot]

On Wed Oct 29, 2025 at 5:24 AM JST, John Hubbard wrote:
> On 10/28/25 8:07 AM, Alexandre Courbot wrote:
> ... 
>> The base for this work is `drm-rust-next`, with [2] applied.
>
> Taking a look now, but unable to apply, using those steps. Do you have
> anything else perhaps in your tree?

I tried checking out `drm-rust-next`, applying [2] (single patch, not
the whole series), then this series, and it applied for me - with the
caveat that the posted version of said patch does not build. :/

Yet more evidence that we should maintain the good habit of publishing
trees for our patch series, which I unexcusably omitted here, so here it
is:

https://github.com/Gnurou/linux/tree/nova-vbios-frombytes

>
>
> thanks,
> John Hubbard
>
>> 
>> [1] https://lore.kernel.org/rust-for-linux/DDTRW1P2I4PB.10ZTZDY95JBC5@xxxxxxxxxx/
>> [2] https://lore.kernel.org/rust-for-linux/20251026-nova-as-v1-1-60c78726462d@xxxxxxxxxx/
>> 
>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>> ---
>> Alexandre Courbot (5):
>>       rust: transmute: add `from_bytes_prefix` family of methods
>>       gpu: nova-core: vbios: use FromBytes for PmuLookupTable header
>>       gpu: nova-core: vbios: use FromBytes for PcirStruct
>>       gpu: nova-core: vbios: use FromBytes for BitHeader
>>       gpu: nova-core: vbios: use FromBytes for NpdeStruct
>> 
>>  drivers/gpu/nova-core/vbios.rs | 137 ++++++++++++++++-------------------------
>>  rust/kernel/transmute.rs       |  60 ++++++++++++++++++
>>  2 files changed, 113 insertions(+), 84 deletions(-)
>> ---
>> base-commit: 639291d7c30cec5cf0d9a79371021c2e4404cfc9
>> change-id: 20251028-nova-vbios-frombytes-eb0cbb6a2f11
>> 
>> Best regards,