Re: accel/amdxdna: Fix incorrect command state for timed out job

From: Markus Elfring

Date: Tue Oct 28 2025 - 16:43:23 EST


>>> When a command times out, mark it as ERT_CMD_STATE_TIMEOUT. Any other
>>> commands that are canceled due to this timeout should be marked as
>>> ERT_CMD_STATE_ABORT.
>> Would it become helpful to use additional labels for the same state settings?
>> https://elixir.bootlin.com/linux/v6.18-rc3/source/drivers/accel/amdxdna/aie2_ctx.c#L197-L226
>
> I do not fully understand your comment. Could you explain more?

Do you propose to use the same state settings in a few if branches?
How do you think about to avoid duplicate statements accordingly?

Regards,
Markus