Re: [PATCH v5 1/2] dma-mapping: benchmark: Restore padding to ensure uABI remained consistent

[Barry Song]

On Tue, Oct 28, 2025 at 8:09 PM Qinxin Xia <xiaqinxin@xxxxxxxxxx> wrote:
>
> The padding field in the structure was previously reserved to
> maintain a stable interface for potential new fields, ensuring
> compatibility with user-space shared data structures.
> However,it was accidentally removed by tiantao in a prior commit,
> which may lead to incompatibility between user space and the kernel.
>
> This patch reinstates the padding to restore the original structure
> layout and preserve compatibility.
>
> Fixes: 8ddde07a3d28 ("dma-mapping: benchmark: extract a common header file for map_benchmark definition")

It would be preferable to include the following as well:

Reported-by: Barry Song <baohua@xxxxxxxxxx>
Closes: https://lore.kernel.org/lkml/CAGsJ_4waiZ2+NBJG+SCnbNk+nQ_ZF13_Q5FHJqZyxyJTcEop2A@xxxxxxxxxxxxxx/

> Cc: stable@xxxxxxxxxxxxxxx
> Acked-by: Barry Song <baohua@xxxxxxxxxx>
> Signed-off-by: Qinxin Xia <xiaqinxin@xxxxxxxxxx>

Thank you. We also need to include Jonathan’s tag[1]:

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>

[1] https://lore.kernel.org/lkml/20250616105318.00001132@xxxxxxxxxx/

I assume Marek can assist with adding those tags when you apply the patch?

Thanks
Barry