Re: [PATCH 02/12] dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema
From: Rob Herring (Arm)
Date: Tue Oct 28 2025 - 13:29:09 EST
On Tue, 28 Oct 2025 16:31:51 +0100, Krzysztof Kozlowski wrote:
> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
> possible properties (19 supplies). Split common part and
> qcom,qca2066-bt to separate bindings, so each schema will be easier to
> read/maintain and list only relevant properties.
>
> The existing bindings do not mention interrupts, but
> am335x-sancloud-bbe-extended-wifi.dts already defines such. This issue
> is not being fixed here.
>
> Existing binding also did not mention any supplies (which do exist as
> confirmed in datasheet) and Linux driver does not ask for any, thus keep
> this state unchanged.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Expected warnings:
> arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
> ---
> .../net/bluetooth/qcom,bluetooth-common.yaml | 25 +++++++++++
> .../bindings/net/bluetooth/qcom,qca2066-bt.yaml | 49 ++++++++++++++++++++++
> .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 24 -----------
> MAINTAINERS | 1 +
> 4 files changed, 75 insertions(+), 24 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Lexical error: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts:53.42-58 Unexpected 'GPIO_ACTIVE_HIGH'
Lexical error: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts:54.42-58 Unexpected 'GPIO_ACTIVE_HIGH'
FATAL ERROR: Syntax error parsing input tree
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1528: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251028-dt-bindings-qcom-bluetooth-v1-2-524a978e3cda@xxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.